10000 Allow Upper Case property names by insekticid · Pull Request #1030 · api-platform/core · GitHub
[go: up one dir, main page]
Skip to content

Allow Upper Case property names #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow Upper Case property names #1030

wants to merge 1 commit into from

Conversation

insekticid
Copy link
Contributor
@insekticid insekticid commented Apr 4, 2017 •
edited
Loading

ReflectionExtractor::getProperties() returns $id instead of $Id. It is bad naming convention, but is possible

class Entity {
    protected $Id;

    public function getId()
    {
        return $this->Id;
    }
}

symfony/symfony#22265

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets #1026
License MIT

@insekticid
Allow Upper Case property names
4a586dd 
ReflectionExtractor::getProperties() returns $id instead of $Id. It is bad naming convention, but is possible

```
class Entity {
    protected $Id;

    public function getId()
    {
        return $this->Id;
    }
}
```

symfony/symfony#22265
dunglas
dunglas approved these changes Apr 4, 2017
View reviewed changes
Copy link
Member
@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dunglas
Copy link
Member
dunglas commented Apr 4, 2017

Can you cover this with an unit test?

@meyerbaptiste
Copy link
Member
meyerbaptiste commented Apr 4, 2017 •
edited
Loading

Is this PR really useful? #1026 (comment)

EDIT: Okay my bad, useful when the annotation is on the method instead of the property.

soyuka
soyuka requested changes Apr 4, 2017
View reviewed changes
Copy link
Member
@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test :)

@insekticid insekticid closed this Apr 7, 2017
@insekticid insekticid deleted the patch-1 branch April 7, 2017 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka requested changes

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@insekticid @dunglas @meyerbaptiste @soyuka
0