E525 fix(build/backend): migrate to deps-free `pygeohash` with pre-built wheels at runtime by hainenber · Pull Request #37524 · apache/superset · GitHub
[go: up one dir, main page]
Skip to content

fix(build/backend): migrate to deps-free pygeohash with pre-built wheels at runtime #37524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hainenber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(build/backend): migrate to deps-free pygeohash with pre-built wheels at runtime #37524

hainenber wants to merge 1 commit into from
+27 −19

Conversation

@hainenber
Copy link
Contributor
@hainenber hainenber commented Jan 28, 2026 •
edited
Loading

fix(build/backend): migrate to deps-free pygeohash with pre-built wheels at runtime

SUMMARY

Fixes #37297

Allows users to run Superset container without pip/uv trying to compile C++ extension for python-geohash. The library introduced in this PR, pygeohash, provides pre-built wheels that play well with modern platforms. API-wise, there are little changes except for .bbox() method but thanks to Gemini's solution, this can be considered as patched.

While the newly migrated library is slower than the status quo, it definitely helps with cross-platform usability as a whole.

CI should be green as acceptance threshold.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
fix(build/backend): migrate to deps-free pygeohash with pre-built w…
6714d2b 
…heels if needed

Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review
Copy link
Contributor
bito-code-review bot commented Jan 28, 2026 •
edited
Loading

Code Review Agent Run #d600aa

Actionable Suggestions - 0
Review Details
  • Files reviewed - 5 · Commit Range: 6714d2b..6714d2b
    • pyproject.toml
    • requirements/base.txt
    • requirements/development.txt
    • superset/utils/pandas_postprocessing/geography.py
    • superset/viz.py
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • MyPy (Static Code Analysis) - ✔︎ Successful
    • Astral Ruff (Static Code Analysis) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the change:backend Requires changing the backend label Jan 28, 2026
@hainenber hainenber changed the title fix(build/backend): migrate to deps-free pygeohash with pre-built wheels if needed fix(build/backend): migrate to deps-free pygeohash with pre-built wheels at runtime Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

change:backend Requires changing the backend size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python-geohash fails to build due to missing C++ toolchain in official image

1 participant

@hainenber
0