8000 fix(Multilayer): preserve dashboard context for embedded by msyavuz · Pull Request #37495 · apache/superset · GitHub
[go: up one dir, main page]
Skip to content

fix(Multilayer): preserve dashboard context for embedded #37495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
msyavuz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(Multilayer): preserve dashboard context for embedded #37495

msyavuz wants to merge 3 commits into from
+85 −0

Conversation

@msyavuz
Copy link
Member
@msyavuz msyavuz commented Jan 27, 2026 •
edited
Loading

SUMMARY

Fixes deck.gl Multiple Layers charts failing to load in embedded mode with datasource permission errors. The issue occurs because child layer requests don't include the dashboard
context (dashboardId) in their form data, causing the security check to fail even though the guest user has access to the dashboard.

The fix ensures that when deck.gl Multiple Layers loads child slices via separate API calls, it preserves the dashboard context from the parent chart, allowing the backend to properly
validate guest user permissions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create a deck.gl Multiple Layers chart with 2+ child layers (Arc, Path, Scatter, etc.)
  2. Add it to a dashboard and enable embedded mode
  3. Set up guest role with minimal permissions:
    - can read on Dashboard
    - can explore on Superset
    - can explore_json on Superset
    - can dashboard on Superset
    - can read on CurrentUserRestApi
    - Do NOT grant datasource-specific permissions
  4. Generate guest token and access embedded dashboard
  5. Verify deck.gl Multiple Layers chart loads data correctly without permission errors

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@msyavuz msyavuz marked this pull request as ready for review January 28, 2026 09:28
@dosubot dosubot bot added the viz:charts:deck.gl Related to deck.gl charts label Jan 28, 2026
@netlify
Copy link
netlify bot commented Jan 28, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 1270152
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6979d6b7e473dd0008e0de6e
😎 Deploy Preview https://deploy-preview-37495--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bito-code-review
Copy link
Contributor
bito-code-review bot commented Jan 28, 2026 •
edited
Loading

Code Review Agent Run #e1f1bb

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: c81e528..1270152
    • superset-frontend/plugins/legacy-preset-chart-deckgl/src/Multi/Multi.test.tsx
    • superset-frontend/plugins/legacy-preset-chart-deckgl/src/Multi/Multi.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geido geido geido approved these changes

Assignees

No one assigned

Labels

plugins preset-io size/M viz:charts:deck.gl Related to deck.gl charts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msyavuz @geido
0