[WIP][SPARK-55241][SQL]. Fix SQL Streaming idempotency broken, with PropagateEmptyRelation and InferFiltersFromConstraint run as part of Fixed Number of iterations #54022
+78
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teEmptyRelation and InferFiltersFromConstraint run as part of Fixed Number of iterations
JIRA Issue Information=== Bug SPARK-55241 === This comment was automatically generated by GitHub Actions |
…teEmptyRelation and InferFiltersFromConstraint run as part of Fixed Number of iterations
…teEmptyRelation and InferFiltersFromConstraint run as part of Fixed Number of iterations
…teEmptyRelation and InferFiltersFromConstraint run as part of Fixed Number of iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PropagteEmptyRelation rule transformation is now skipped for Filter Node if streaming is true.
Why are the changes needed?
The change is needed to ensure idempotency is achieved for streaming relations if PropagateEmptyRelation and InferFiltersFromConstraint rules are run as part of Fixed Iterations. Because the tramsform is already being skipped for Join node in case of streaming relation, it should similarly be skipped for Filter Node too, else the behaviour clashes with the InferFilterFromConstraints rule.
The need for "InferFiltersFromConstraint" to be run as FixedPoint is needed for the following PR
#53838
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added bug test/
Was this patch authored or co-authored using generative AI tooling?
No