8000 [WIP][DO-NOT-MERGE] Test the -Yrepl-class-based changes by dwijnand · Pull Request #27681 · apache/spark · GitHub
[go: up one dir, main page]
Skip to content

[WIP][DO-NOT-MERGE] Test the -Yrepl-class-based changes #27681

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[WIP][DO-NOT-MERGE] Test the -Yrepl-class-based changes #27681

wants to merge 5 commits into from

Conversation

dwijnand
Copy link

Hi! This PR is to test the change to the scala compiler's -Yrepl-class-based option (which the Spark REPL uses) that landed in scala/scala#8712.

I don't expect it to be merged. :)

I tested this locally with:

./build/mvn -P scala-integration -Dscala.version=2.12.11-bin-4c726db -pl :spark-repl_2.12 -Dtest=none -DwildcardSuites='org.apache.spark.repl.ReplSuite,org.apache.spark.repl.SingletonReplSuite,org.apache.spark.repl.ExecutorClassLoaderSuite' test

and that subset passed for me. I'm interested to see if those or any other tests fail in CI.

@dwijnand
Copy link
Author

Could anyone tell me in which check tests like ReplSuite are run, please?

@srowen
Copy link
Member
srowen commented Feb 24, 2020

Jenkins test this please

@srowen srowen changed the title [WIP] Test the -Yrepl-class-based changes [WIP][DO-NOT-MERGE] Test the -Yrepl-class-based changes Feb 24, 2020
@srowen
Copy link
Member
srowen commented Feb 24, 2020

@dwijnand It should run all tests as the parent POM changed, including ReplSuite.
8000

@SparkQA
Copy link
SparkQA commented Feb 24, 2020

Test build #118873 has finished for PR 27681 at commit e0db793.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dwijnand
Copy link
Author

Could someone run Jenkins again, please?

@srowen
Copy link
Member
srowen commented Feb 25, 2020

Jenkins, OK to test

@dwijnand
Copy link
Author

Is there another incantation to get it to run again?

@srowen
Copy link
Member
srowen commented Feb 28, 2020

Jenkins test this please

@SparkQA
Copy link
SparkQA commented Feb 28, 2020

Test build #119091 has finished for PR 27681 at commit 7eaea97.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dwijnand
Copy link
Author
dwijnand commented Mar 5, 2020

Jenkins test this please

1 similar comment
@srowen
Copy link
Member
srowen commented Mar 16, 2020

Jenkins test this please

@srowen
Copy link
Member
srowen commented Mar 16, 2020

Jenkins add to whitelist

@SparkQA
Copy link
SparkQA commented Mar 16, 2020

Test build #119871 has finished for PR 27681 at commit cfc612d.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dwijnand
Copy link
Author

Too late to change any details on this now: https://github.com/scala/scala/releases/tag/v2.12.11

Let us know if you notice any impact from upgrading.

@dwijnand dwijnand closed this Mar 16, 2020
@dwijnand dwijnand deleted the test-class-based-tweaks branch March 16, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwijnand @srowen @SparkQA
0