Fix the Maven Central badge#1042
Merged
lprimak merged 2 commits intoapache:mainfrom Aug 23, 2023
marcelstoer:main-1
Merged
Conversation
The badge should actually link to Central.
bdemers
approved these changes
Aug 23, 2023
Member
|
Awesome! thanks @marcelstoer |
Contributor
Author
|
Using https://github.com/softwaremill/maven-badges instead of shields.io for the Maven badge would give us a little more convenience but I deemed my current fix good enough for most. |
lprimak
requested changes
Aug 23, 2023
Contributor
There was a problem hiding this comment.
Shouldn't this be https://central.sonatype.com/ instead?
Contributor
Author
|
I have no preference, we might just as well link to https://central.sonatype.com/artifact/org.apache.shiro/shiro-core/ instead. However, I somehow feel that search.maven.org is going to be stable far longer than central.sonatype.com. |
Contributor
|
Well, it's a redirect now, so I feel like sonatype.org would better. I talked to some folks at sonatype and they say "big changs" are coming, so I would say the new stuff is gonna stick around :) |
bdemers
approved these changes
Aug 23, 2023
lprimak
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The badge should actually link to Central.
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.