Fix - markersDirectory is not working when unpack goal is executed from command line #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
reviewed
Jun 18, 2025
|
@elharo Can you point me to any existing integration test written in this project? |
| @@ -55,7 +55,9 @@ public class UnpackMojo extends AbstractFromConfigurationMojo { | |||
| /** | |||
| * Directory to store flag files after unpack | |||
| */ | |||
| @Parameter(defaultValue = "${project.build.directory}/dependency-maven-plugin-markers") | |||
| @Parameter( | |||
| property = "markersDirectory", | |||
There was a problem hiding this comment.
I would like to change it to mdep.unpack.markersDirectory as we have for other parameters
There was a problem hiding this comment.
I've kept it consistent with unpack-dependencies goal:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #536
Property attribute is missing in @parameter annotation from markersDirectory attribute in UnpackMojo due to which its not working from command line.