fix: redirect only error output from makefile command to do not install uv if already present on system #2742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hey @raulcd curious which shell are you using? im using zsh and not im seeing this behavior this change will output an extra |
Member
Author
That's curious, I'm using bash. My Makefile skills are slightly rusty but, as I can reproduce, I can keep investigating and find a different approach that works with both bash and zsh. |
kevinjqliu
reviewed
Dec 26, 2025
|
|
||
| install-uv: ## Ensure uv is installed | ||
| @if ! command -v uv &> /dev/null; then \ | ||
| @if ! command -v uv 2> /dev/null; then \ |
Contributor
There was a problem hiding this comment.
Suggested change
| @if ! command -v uv 2> /dev/null; then \ | |
| @if ! command -v uv > /dev/null 2>&1; then \ |
&> is bash-specific syntax. > /dev/null 2>&1 is POSIX-compliant and works across all shells, ensuring the Makefile is portable to systems where /bin/sh isn't bash (like Ubuntu's dash).
Same behavior, better compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2741
Rationale for this change
make installis currently trying to installuveven when is present locally:$ make install uv not found. Installing... /home/raulcd/.local/bin/uv ^Cmake: *** [Makefile:62: install-uv] Interrupt $ uv --version uv 0.9.7Are these changes tested?
No, only validated locally on Debian 14 that it does not try to install:
And validated in a clean docker container that if
uvis not present it installs it:Are there any user-facing changes?
No