fix loading in-memory catalog
#1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungwy
approved these changes
Feb 26, 2025
Collaborator
There was a problem hiding this comment.
Interesting issue :)
Thanks for the fix @kevinjqliu !
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
Previously `CatalogType` was fetched by key, `CatalogType[provided_catalog_type.upper()]` (note the bracket) This PR changes `CatalogType` to be fetched by value, `CatalogType(provided_catalog_type.lower())` (note the parenthesis) https://stackoverflow.com/questions/29799235/python-enum-value2member-map-accessor This fix loading `in-memory` catalog, `load_catalog("catalog", **{"type": "in-memory"})`. Previously, `"in-memory"` caused a key error because its key is `IN_MEMORY`. Note the `-` vs `_`. https://github.com/apache/iceberg-python/blob/1d24e71041e35e26e126aa4508ed7384e8aa031c/pyiceberg/catalog/__init__.py#L113-L119 We want `in-memory` and not `in_memory` to match spark https://github.com/apache/iceberg-python/blob/1d24e71041e35e26e126aa4508ed7384e8aa031c/dev/spark-defaults.conf#L35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
CatalogTypewas fetched by key,CatalogType[provided_catalog_type.upper()](note the bracket)This PR changes
CatalogTypeto be fetched by value,CatalogType(provided_catalog_type.lower())(note the parenthesis)https://stackoverflow.com/questions/29799235/python-enum-value2member-map-accessor
This fix loading
in-memorycatalog,load_catalog("catalog", **{"type": "in-memory"}).Previously,
"in-memory"caused a key error because its key isIN_MEMORY. Note the-vs_.iceberg-python/pyiceberg/catalog/__init__.py
Lines 113 to 119 in 1d24e71
We want
in-memoryand notin_memoryto match sparkiceberg-python/dev/spark-defaults.conf
Line 35 in 1d24e71