E531 feat: use dictionary type to store column by tanruixiang · Pull Request #993 · apache/horaedb · GitHub
[go: up one dir, main page]
Skip to content

feat: use dictionary type to store column #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiacai2050 merged 19 commits into from
Jul 5, 2023
Merged

feat: use dictionary type to store column #993

jiacai2050 merged 19 commits into from
Jul 5, 2023

Conversation

@tanruixiang
Copy link
Member
@tanruixiang tanruixiang commented Jun 15, 2023 •
edited
Loading

Rationale

close #1039

Detailed Changes

Add dictionary type

Test Plan

ut.

@tanruixiang tanruixiang marked this pull request as ready for review June 28, 2023 07:07
@tanruixiang tanruixiang requested a review from jiacai2050 June 28, 2023 07:07
jiacai2050
jiacai2050 reviewed Jul 3, 2023
View reviewed changes
@tanruixiang tanruixiang requested a review from jiacai2050 July 4, 2023 03:38
jiacai2050
jiacai2050 reviewed Jul 4, 2023
View reviewed changes
jiacai2050
jiacai2050 reviewed Jul 4, 2023
View reviewed changes
jiacai2050
jiacai2050 reviewed Jul 4, 2023
View reviewed changes
jiacai2050
jiacai2050 reviewed Jul 5, 2023
View reviewed changes
jiacai2050
jiacai2050 reviewed Jul 5, 2023
View reviewed changes
jiacai2050
jiacai2050 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor
@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 4a7c6e4 into apache:main Jul 5, 2023
@tanruixiang tanruixiang deleted the support_dictionary branch July 12, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support write and read dictionary encoding column

2 participants

@tanruixiang @jiacai2050
0