E52C chore: remove useless code by chunshao90 · Pull Request #906 · apache/horaedb · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@chunshao90
Copy link
Contributor
@chunshao90 chunshao90 commented May 19, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Remove useless pub(crate).

What changes are included in this PR?

  • Remove useless pub(crate).
  • Remove useless #[allow(dead_code)].

Are there any user-facing changes?

No.

How does this change test

CI.

@chunshao90 chunshao90 force-pushed the chore-remove-useless-code branch from 22ca4cf to 6401050 Compare May 19, 2023 06:03
@chunshao90 chunshao90 marked this pull request as ready for review May 19, 2023 06:05
@chunshao90 chunshao90 requested review from ShiKaiWi and jiacai2050 May 19, 2023 07:38
Copy link
Contributor
@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 6051546 into apache:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0