10BC0 refactor: proxy sql read by chunshao90 · Pull Request #896 · apache/horaedb · GitHub
[go: up one dir, main page]
Skip to content

refactor: proxy sql read #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chunshao90 merged 2 commits into from
May 17, 2023
Merged

refactor: proxy sql read #896

chunshao90 merged 2 commits into from
May 17, 2023

Conversation

@chunshao90
Copy link
Contributor
@chunshao90 chunshao90 commented May 16, 2023 •
edited
Loading

Which issue does this PR close?

Closes #

Rationale for this change

Refactor the proxy module to remove some duplicate code.

What changes are included in this PR?

  • Refactor proxy sql query.

Are there any user-facing changes?

No.

How does this change test

CI.

@chunshao90 chunshao90 force-pushed the refactor-proxy-query branch 2 times, most recently from c33c221 to a386fba Compare May 16, 2023 08:36
@chunshao90 chunshao90 marked this pull request as ready for review May 16, 2023 08:38
@jiacai2050 jiacai2050 self-requested a review May 16, 2023 08:50
jiacai2050
jiacai2050 reviewed May 16, 2023
View reviewed changes
@chunshao90 chunshao90 force-pushed the refactor-proxy-query branch from 86dc711 to aeb1450 Compare May 17, 2023 04:53
jiacai2050
jiacai2050 approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor
@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 force-pushed the refactor-proxy-query branch from aeb1450 to 3939968 Compare May 17, 2023 06:40
@chunshao90 chunshao90 merged commit 1d08bd6 into apache:main May 17, 2023
@chunshao90 chunshao90 mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunshao90 @jiacai2050
0