feat: place table datas into manifest, update them together #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55dcf8e to
00defb3
Compare
b488828 to
d4e4ac4
Compare
d4e4ac4 to
cb1567c
Compare
3c4b191 to
4ebe4d8
Compare
4ebe4d8 to
b056310
Compare
ShiKaiWi
reviewed
May 8, 2023
2be904a to
f80557c
Compare
f80557c to
60e6e6c
Compare
chunshao90
pushed a commit
to chunshao90/ceresdb
that referenced
this pull request
May 15, 2023
## Which issue does this PR close? Closes # Part of apache#799 ## Rationale for this change Now, we update `TableData` and store its wal seperately. The order of two operations above is maintained by developer, that will lead to a big bug if developer is not so careful when modifying related codes. <!--- Why are you proposing this change? If this is already explained clearly in the issue, then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? + Place table datas into manifest. + Update it both in memory and storage in the same call. <!--- There is no need to duplicate the description in the issue here, but it is sometimes worth providing a summary of the individual changes in this PR to help reviewers understand the structure. --> ## Are there any user-facing changes? None. <!--- Please mention if: - there are user-facing changes that need to update the documentation or configuration. - this is a breaking change to public APIs --> ## How does this change test Test by ut. <!-- Please describe how you test this change (like by unit test case, integration test or some other ways) if this change has touched the code. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Part of #799
Rationale for this change
Now, we update
TableDataand store its wal seperately. The order of two operations above is maintained by developer, that will lead to a big bug if developer is not so careful when modifying related codes.What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Test by ut.