8000 refactor: shard lock module by ShiKaiWi · Pull Request #853 · apache/horaedb · GitHub
[go: up one dir, main page]
Skip to content

refactor: shard lock module #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShiKaiWi merged 9 commits into from
Apr 25, 2023
Merged

refactor: shard lock module #853

ShiKaiWi merged 9 commits into from
Apr 25, 2023

Conversation

@ShiKaiWi
Copy link
Member
@ShiKaiWi ShiKaiWi commented Apr 21, 2023

Which issue does this PR close?

Closes #

Rationale for this change

There are some issues remaining in the #706.

What changes are included in this PR?

Are there any user-facing changes?

None.

How does this change test

Existing tests.

@ShiKaiWi ShiKaiWi force-pushed the refactor-shard-lock branch 2 times, most recently from a66b807 to 80b0efa Compare April 24, 2023 04:30
@ShiKaiWi ShiKaiWi force-pushed the refactor-shard-lock branch from 80b0efa to a1bcd3b Compare April 24, 2023 04:30
jiacai2050
jiacai2050 reviewed Apr 25, 2023
View reviewed changes
jiacai2050
jiacai2050 reviewed Apr 25, 2023
View reviewed changes
Rachelint
Rachelint reviewed Apr 25, 2023
View reviewed changes
@ShiKaiWi ShiKaiWi force-pushed the refactor-shard-lock branch from 0f6486d to 8c8c9d0 Compare April 25, 2023 04:48
jiacai2050
jiacai2050 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor
@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShiKaiWi ShiKaiWi merged commit d127005 into apache:main Apr 25, 2023
@ShiKaiWi ShiKaiWi deleted the refactor-shard-lock branch April 25, 2023 06:04
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@ShiKaiWi
refactor: shard lock module (apache#853)
e39ce2e 
* refactor: shard lock module

* chore: classify whether the lock release is in purpose

* fix: allow ceresmeta restarting

* fix: wait background keepalive exit before next grant

* feat: support retry for keeping alive

* chore: rename mutex and rwlock

* fix: allow exit when schedule next keepalive

* feat: determine rpc_time by ttl

* chore: comments to explain the retry logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rachelint Rachelint Rachelint left review comments

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShiKaiWi @jiacai2050 @Rachelint
0