8000 feat: add go sdk tests by jiacai2050 · Pull Request #686 · apache/horaedb · GitHub
[go: up one dir, main page]
Skip to content

feat: add go sdk tests #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShiKaiWi merged 1 commit into from
Mar 3, 2023
Merged

feat: add go sdk tests #686

ShiKaiWi merged 1 commit into from
Mar 3, 2023

Conversation

@jiacai2050
Copy link
Contributor
@jiacai2050 jiacai2050 commented Mar 2, 2023 •
edited
Loading

Which issue does this PR close?

Part of #685

Rationale for this change

What changes are included in this PR?

  • Add go sdk tests
    • Write 2 rows, read back, and drop table at last.

Are there any user-facing changes?

No

How does this change test

CI

@jiacai2050 jiacai2050 requested review from ShiKaiWi and mrrtree March 2, 2023 06:37
@codecov-commenter
Copy link
codecov-commenter commented Mar 2, 2023

Codecov Report

Merging #686 (ed6f5bf) into main (f0b687b) will increase coverage by 0.00%.
The diff coverage is 9.09%.

❗ Current head ed6f5bf differs from pull request most recent head baf0a8d. Consider uploading reports for the commit baf0a8d to get more accurate results

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   67.54%   67.55%           
=======================================
  Files         281      281           
  Lines       44302    44301    -1     
=======================================
+ Hits        29925    29927    +2     
+ Misses      14377    14374    -3
Impacted Files Coverage Δ
cluster/src/config.rs 75.00% <ø> (-2.78%) ⬇️
components/logger/src/lib.rs 27.98% <0.00%> (ø)
server/src/config.rs 38.09% <ø> (+0.88%) ⬆️
server/src/grpc/storage_service/mod.rs 45.11% <0.00%> (-0.02%) ⬇️
server/src/grpc/storage_service/write.rs 39.42% <0.00%> (+0.21%) ⬆️
server/src/http.rs 0.00% <ø> (ø)
analytic_engine/src/manifest/details.rs 95.47% <28.57%> (-0.47%) ⬇️
analytic_engine/src/row_iter/merge.rs 89.18% <0.00%> (+0.17%) ⬆️
components/skiplist/src/list.rs 99.09% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ShiKaiWi
ShiKaiWi reviewed Mar 3, 2023
View reviewed changes
@ShiKaiWi ShiKaiWi added this pull request to the merge queue Mar 3, 2023
Merged via the queue into apache:main with commit 28402e4 Mar 3, 2023
@jiacai2050 jiacai2050 deleted the test-go-sdk branch March 3, 2023 08:14
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
feat: add go sdk tests (apache#686)
cff7c77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

@mrrtree mrrtree Awaiting requested review from mrrtree

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiacai2050 @codecov-commenter @ShiKaiWi
0