8000 chore: push nightly image to ghcr.io by jiacai2050 · Pull Request #684 · apache/horaedb · GitHub
[go: up one dir, main page]
Skip to content

chore: push nightly image to ghcr.io #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chunshao90 merged 1 commit into from
Mar 2, 2023
Merged

chore: push nightly image to ghcr.io #684

chunshao90 merged 1 commit into from
Mar 2, 2023

Conversation

@jiacai2050
Copy link
Contributor
@jiacai2050 jiacai2050 commented Mar 2, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Separate nightly images from public release images

What changes are included in this PR?

Change registry to github

Are there any user-facing changes?

No

How does this change test

No need

@codecov-commenter
Copy link
codecov-commenter commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #684 (c089fb0) into main (f0b687b) will increase coverage by 0.00%.
The diff coverage is 9.09%.

❗ Current head c089fb0 differs from pull request most recent head fe5205e. Consider uploading reports for the commit fe5205e to get more accurate results

@@           Coverage Diff           @@
##             main     #684   +/-   ##
=======================================
  Coverage   67.54%   67.54%           
=======================================
  Files         281      281           
  Lines       44302    44301    -1     
=======================================
  Hits        29925    29925           
+ Misses      14377    14376    -1
Impacted Files Coverage Δ
cluster/src/config.rs 75.00% <ø> (-2.78%) ⬇️
components/logger/src/lib.rs 27.98% <0.00%> (ø)
server/src/config.rs 38.09% <ø> (+0.88%) ⬆️
server/src/grpc/storage_service/mod.rs 45.11% <0.00%> (-0.02%) ⬇️
server/src/grpc/storage_service/write.rs 39.42% <0.00%> (+0.21%) ⬆️
server/src/http.rs 0.00% <ø> (ø)
analytic_engine/src/manifest/details.rs 95.47% <28.57%> (-0.47%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

chunshao90
chunshao90 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor
@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90 chunshao90 added this pull request to the merge queue Mar 2, 2023
Merged via the queue into apache:main with commit 6480591 Mar 2, 2023
@jiacai2050 jiacai2050 deleted the fix-nightly branch March 2, 2023 03:39
@jiacai2050 jiacai2050 mentioned this pull request Mar 2, 2023
Merged
chunshao90 pushed a commit to chunshao90/ceresdb that referenced this pull request May 15, 2023
@jiacai2050
chore: push nightly image to ghcr.io (apache#684)
d22fdb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunshao90 chunshao90 chunshao90 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiacai2050 @codecov-commenter @chunshao90
0