8000 chore: add mysql-client and grafana in docker image by dracoooooo · Pull Request #1530 · apache/horaedb · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@dracoooooo
Copy link
Contributor
@dracoooooo dracoooooo commented May 10, 2024

Rationale

Close #1285

Install mysql-client and grafana when building docker image.

Detailed Changes

  1. Install mysql-client and grafana in Dockerfile.
  2. Add docker/datasource.yml as grafana default datasource.
  3. Start grafana server in entrypoint.sh.

mysql-client

In the docker container:

image

grafana

Start the container and access http://<your_ip>:3000

image

Test Plan

None.

@github-actions github-actions bot added the chore label May 10, 2024
@jiacai2050
Copy link
Contributor

Hi, in description you said test plan is none, would me mind to insert some data, and see if mysql datasource works?

There are example telling you how to insert in readme.

@dracoooooo
Copy link
Contributor Author

Hi @jiacai2050. MySQL datasource works well in my local test with the queries in readme.

image

Copy link
Contributor
@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit cf5ec10 into apache:main May 12, 2024
@jiacai2050
Copy link
Contributor

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docker image for more user-friendly usage

2 participants

0