8000 build(deps): upgrade rust-rocksdb by tisonkun · Pull Request #1223 · apache/horaedb · GitHub
[go: up one dir, main page]
Skip to content

build(deps): upgrade rust-rocksdb #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiacai2050 merged 2 commits into from
Sep 20, 2023
Merged

build(deps): upgrade rust-rocksdb #1223

jiacai2050 merged 2 commits into from
Sep 20, 2023

Conversation

@tisonkun
Copy link
Member
@tisonkun tisonkun commented Sep 19, 2023

Rationale

This closes #1222.

Fix compilation on macOS M1.

Detailed Changes

Upgrade TiKV's RocksDB crate to a new commit.

Test Plan

Existing CI workflows.

@tisonkun
build(deps): upgrade rust-rocksdb
360382e 
Signed-off-by: tison <wander4096@gmail.com>
@CLAassistant
Copy link
CLAassistant commented Sep 19, 2023 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link
CLAassistant commented Sep 19, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

ShiKaiWi
ShiKaiWi approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member
@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ShiKaiWi
ShiKaiWi approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member
@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050
Copy link
Contributor
jiacai2050 commented Sep 20, 2023

Do this update fix your issue?

I also have this issue in my macbook, the solution I use is comment L774:

    if !ident_ok(string) {
        //panic!("{:?} is not a valid Ident", string);
    }

It seems the generated variable is not used at all.

@tisonkun
Copy link
Member Author
tisonkun commented Sep 20, 2023

Do this update fix your issue?

Yes.

@jiacai2050 jiacai2050 merged commit 20ee56e into apache:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot build librocksdb-sys on macOS with Apple M1 chip

4 participants

@tisonkun @CLAassistant @jiacai2050 @ShiKaiWi
0