8000 feat: make float as number encoding by ShiKaiWi · Pull Request #1171 · apache/horaedb · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ShiKaiWi
Copy link
Member

Rationale

Encoding float values in columnar way is not supported yet.

Detailed Changes

Support encode float values.

Test Plan

New unit tests.

@ShiKaiWi ShiKaiWi marked this pull request as draft August 24, 2023 08:09
@ShiKaiWi ShiKaiWi marked this pull request as ready for review August 24, 2023 11:31
Copy link
Contributor
@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 8fd225f into apache:main Aug 24, 2023
@ShiKaiWi ShiKaiWi deleted the feat-columnar-encoding-float branch August 24, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0