HADOOP-19540. [JDK17] Add ubuntu:noble as a build platform with JDK-17 as default #7608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushtkn
reviewed
Apr 12, 2025
There was a problem hiding this comment.
The error message on aarch64 ain't cheese
ayushsaxena@ayushsaxena hadoop % ./start-build-env.sh ubuntu_24
[+] Building 0.0s (2/2) FINISHED
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [internal] load build definition from Dockerfile_ubuntu_24_aarch64 0.0s
=> => transferring dockerfile: 2B 0.0s
ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount1675973539/Dockerfile_ubuntu_24_aarch64: no such file or directory
ayushsaxena@ayushsaxena hadoop %
Can we update the BUILDING.txt to reflect which ones are supported for aarch64.
Rest if the build comes clean, changes LGTM
|
💔 -1 overall
This message was automatically generated. |
|
All the failures in compilation are due to below. Nothing to do with changes in this PR. |
877f792 to
0db1122
Compare
Ack. Updated the BUILDING.txt and added error message in |
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Apr 14, 2025
|
💔 -1 overall
This message was automatically generated. |
|
Ran the failed tests locally.. |
0db1122 to
bcd73e6
Compare
|
💔 -1 overall
This message was automatically generated. |
pan3793
reviewed
Apr 22, 2025
pan3793
reviewed
Apr 22, 2025
pan3793
reviewed
Apr 22, 2025
8000
...-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/include/hdfspp/block_location.h
Outdated
Show resolved
Hide resolved
cnauroth
approved these changes
Apr 23, 2025
There was a problem hiding this comment.
+1 from me, pending resolution of the last round of feedback from @pan3793 . Thanks @vinayakumarb !
…7 as default 1. Added "ubuntu:noble" to supported docker platforms. 2. Modified `start-build-env.sh` to use expected Dockerfiles dynamically. ex: `bash start-build-env.sh ubuntu_24` where `ubuntu_24` is the extra suffix in the name of the Dockerfile. 3. Added `jdk17++` profile activated when jdk17 is available. Successfully built the entire Hadoop tar with native support on env created using `bash start-build-env.sh ubuntu_24`
bcd73e6 to
1bea33c
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Thanks everyone for reviews. |
@vinayakumarb Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing
2FC0
a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
start-build-env.shto use expected Dockerfiles dynamically. ex:bash start-build-env.sh ubuntu_24whereubuntu_24is the extra suffix in the name of the Dockerfile.jdk17profile activated when jdk17 is available.#include <stdint.h>to header files which misses it to successfully compile with g++ (13.3) in ubuntu 24.How was this patch tested?
Successfully built the entire Hadoop tar with native support on env created using
bash start-build-env.sh ubuntu_24For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?