-
Notifications
You must be signed in to change notification settings - Fork 9k
HADOOP-19256 Support Conditional Writes in S3A #7329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catching up with this.
I can see it is still part way through doing those first changes I'd suggested. I don't think we need that map of options, I'd rather they get extracted.
we have two create options then
- reject overwrite
- later: require match + etag
the code is very, very similar, all that is different is that the second one needs an etag
we need to think of the best way to get both of these down.
For testing large files, I also want to add an option for "always do a multipart write" -but that can go in as a header with a new option defined.
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatch.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatch.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatch.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatch.java
Outdated
Show resolved
Hide resolved
...ols/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/magic/S3MagicCommitTracker.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/PutObjectOptions.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RequestFactoryImpl.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/RequestFactoryImpl.java
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatch.java
Outdated
Show resolved
Hide resolved
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestS3APutIfMatch.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
b007664
to
ddc772c
Compare
ddc772c
to
b007664
Compare
💔 -1 overall
This message was automatically generated. |
17c0ad9
to
19f3d58
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
with |
- testIfMatchCreateFileWithoutOverwrite, testIfMatchCreateFileWithoutOverwriteWithPerformanceFlag - with the new design, overwrite is ignored if etag is passed
good question. options
for 1 and 2 we log at debug too, obviously I think 1 or 3 is correct, with 3 being the strict one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on this, but merge is blocked on #7479 , which is in progress (I need to test more stores)
4b2dde0
to
210c668
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
210c668
to
6fc0203
Compare
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Description of PR
Cherry-pick of #7011, and additional changes on top of it
How was this patch tested?
integration tests ran on ap-south-1
Failing tests:
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?