8000 Add make_list and tests for make_list, make_array by kosiew · Pull Request #949 · apache/datafusion-python · GitHub
[go: up one dir, main page]

Skip to content

Add make_list and tests for make_list, make_array #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By cli 8000 cking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

kosiew
Copy link
Contributor
@kosiew kosiew commented Nov 14, 2024

Which issue does this PR close?

Completes a task in #463

Rationale for this change

This PR introduces a new function, make_list, which is an alias for the existing make_array function and also tests.

What changes are included in this PR?

Functionality: Added a new function make_list in functions.py, which is an alias for make_array.

Tests: Updated test_functions.py to include parameterized tests for both make_array and make_list, ensuring consistency in functionality.

Are there any user-facing changes?

Yes, the addition of the make_list function expands the API, providing users with a new way to achieve the same behavior as make_array.

Copy link
Contributor
@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@timsaucer timsaucer merged commit 92b093c into apache:main Nov 23, 2024
15 checks passed
@kosiew kosiew deleted the add-make-list branch November 25, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0