refactor: from_arrow use protocol typehints
#917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. In regards to dropping the from_pandas and from_polars, I don't think we want to impose people upgrade to the very latest quite yet. I'd recommend revisiting that in ~6months just for stability of the ecosystem. < 86BF /td> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timsaucer we could probably drop the rust code for from_pandas and from_polars and keep those in Python as aliases but just call from_arrow or even drop them. The only thing is we will have to add minimum dependencies since they recently added arrow_c_stream support. For polars that would be v1.3. For pandas I would have to check.
Rationale for this change
AnyWhat changes are included in this PR?
Are there any user-facing changes?
None