10000 Run `maturin develop` instead of `cargo build` in verification script by andygrove · Pull Request #200 · apache/datafusion-python · GitHub
[go: up one dir, main page]
Skip to content

Run maturin develop instead of cargo build in verification script #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2023
+8 −4
Merged

Run maturin develop instead of cargo build in verification script #200

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e695ce2
Run maturin develop in verification script
andygrove Feb 21, 2023
f8925af
venv
andygrove Feb 21, 2023
2c1b7da
comment out test for now
andygrove Feb 21, 2023
4eb9b94
explicit python3
andygrove Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,19 @@ test_source_distribution() {
git clone https://github.com/apache/arrow-testing.git testing
git clone https://github.com/apache/parquet-testing.git parquet-testing

cargo build
cargo test --all
python3 -m venv venv
source venv/bin/activate
python3 -m pip install -U pip
python3 -m pip install -r requirements-310.txt
maturin develop

#TODO: we should really run tests here as well
#python3 -m pytest

if ( find -iname 'Cargo.toml' | xargs grep SNAPSHOT ); then
echo "Cargo.toml version should not contain SNAPSHOT for releases"
exit 1
fi

cargo publish --dry-run
}

TEST_SUCCESS=no
Expand Down
0