fix: recursive import #1117
Merged
fix: recursive import #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much. I also have a branch for this that I was going to push up, but I'll prefer your solution. I do want to add unit tests, so I might push up what I have on those to your branch if that's ok. |
|
Actually, it's going to take a while to get all these unit tests written up so I'll merge your solution in to fix CI and then put my PR up separate. |
This was referenced Apr 28, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No
Rationale for this change
expr depends on functions.
functions depends on expr.
there's a recursive import.
What changes are included in this PR?
import functions when it's needed.
Are there any user-facing changes?
No