Partial fix for 1078: [refactor: Simplify HTML generation in PyDataFrame by extracting helper functions] #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions - Replaced inline HTML string construction with dedicated functions for style definitions, table headers, rows, and cell formatting. - Improved readability and maintainability of the code by modularizing HTML generation logic. - Enhanced the handling of large cell content with expandable text features.
|
Thinking about this and also #1086 does it make sense instead to have a global variable like in I don't have a perfect use case in my mind, but I can imagine a user might want to be able to do either
|
Do you mean something like #1096? |
Yes, I think that issue captures it really well. |
|
Thanks for the confirmation, @timsaucer Closing this to pivot to #1096 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partial fix for #1078
Rationale for this change
The rendering logic for DataFrame HTML output was previously monolithic. By modularizing the generation of HTML structure, styles, and table rows into clearly named helper functions, we improve readability, testability, and long-term maintainability.
This refactor lays the foundation for easier customization.
What changes are included in this PR?
get_html_style_definitions()get_html_table_opening()get_html_table_header()create_batch_formatters()get_html_table_rows()andformat_table_cell()get_html_js_functions()Are there any user-facing changes?
No functional changes for end users. The generated HTML and behavior remain the same, but the underlying implementation is now modular and easier to maintain.