feat: add missing PyLogicalPlan to_variant #1085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really big PR and it's not immediately obvious to me what problem it's trying to solve. Can you expand the description or at least link it to an issue describing the problem? |
@timsaucer |
timsaucer
approved these changes
Apr 27, 2025
|
I'm sorry it took me so long to get around to reviewing this. Thank you for the contribution! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
41CE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Some LogicalPlans don't support to_variant now.
we are using datafusion in parsing sql into logical plan, analysis and do some transformation on logical plan, then unparsing the logical plan into sql. But I found that it will throw error when the logical plan is not supported. so I added the missing to_variant support.
What changes are included in this PR?
add python bindings for these classes.
Are there any user-facing changes?
No