Conversation
tolbertam
approved these changes
Feb 14, 2017
Contributor
There was a problem hiding this comment.
👍 ing since I was 👍 on the previous PR. I'd like to run some perf tests against this to make sure there are no glaring performance degradations, but I expect that to be very unlikely. Since the scope of changes is very small, I think it's ok to merge and if in the oft-chance we hit any problems while perf testing we can always back out then.
This commit also updates netty-tcnative to Fork26, and accounts for netty-transport depending on new netty-resolver module in 4.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit also updates netty-tcnative to Fork26, and
accounts for netty-transport depending on new netty-resolver module in 4.1.