8000 JAVA-1042: Include DSE version and workload in Host data. by adutra · Pull Request #580 · apache/cassandra-java-driver · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@adutra
Copy link
Contributor
@adutra adutra commented Jan 26, 2016

This PR applies the patch by @djatnieks with additional minor changes to the javadocs of Host class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that this can happen even when using DSE as the information isn't populated immediately as the host becomes available on 9042, but eventually the data is populated. This could mean the driver may also not reliably have this data even if using DSE, but doesn't seem likely (except maybe in bootstrap cases). Do we have a way to force refresh of this data? That might be nice to have (this would be a separate request).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like I was wrong about this, the problem was the control host not being set, after that was fixed everything seems to be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like i was somewhat right in that it isn't populated immediately on node start, so having a nice API for forcing a refresh on this might be nice (as a separate pr later).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after doing a little more testing, it seems that newer DSE versions handles this much better. On 4.8.3 I saw that a Solr workload never sets the dse_version column, where it works just fine.

@tolbertam
Copy link
Contributor

Added tests for this and JAVA-1035. Also made a change to refreshNodeListAndTokenMap to handle listen_address in peers table (which C* doesn't currently provide).

@olim7t olim7t added this to the 3.0.0 milestone Jan 27, 2016
@olim7t
Copy link
Contributor
olim7t commented Jan 27, 2016

👍

This commit contains contributions by Andrew Tolbert (@tolbertam),
in particular tests for both JAVA-1042 and JAVA-1035.
adutra added a commit that referenced this pull request Jan 28, 2016
JAVA-1042: Include DSE version and workload in Host data.
@adutra adutra merged commit 377352a into 3.0 Jan 28, 2016
@adutra adutra deleted the java1042 branch January 28, 2016 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0