Document extra codecs #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
I would suggest the term "temporal" to avoid any confusion with the CQL TIME type.
Contributor
There was a problem hiding this comment.
Is there anyway we can parameterize the version here? Either that or we can put some kind of fake templating here like DRIVER_VERSION.
Contributor
Author
There was a problem hiding this comment.
I've thought about that, but the hard part is that we want it to be the version in the sources, because people can browse them from github.com.
We do a global replace before each release, but that's not 100% foolproof.
cf8d3ec to
fd644ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+ minor changes to object mapper doc