8000 Make TableOrView public to allow TableOrView.Option to be referenced outside package. by adutra · Pull Request #463 · apache/cassandra-java-driver · GitHub < 10BC0 meta name="html-safe-nonce" content="61a7269c3a2db0a1a8afbcf9c5e737816719024cb9aa30a71eabecfcef4b3a85" data-pjax-transient="true"/>
[go: up one dir, main page]
Skip to content

Make TableOrView public to allow TableOrView.Option to be referenced outside package. #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olim7t merged 2 commits into from
Oct 14, 2015
Merged

Make TableOrView public to allow TableOrView.Option to be referenced outside package. #463

olim7t merged 2 commits into from
Oct 14, 2015

Conversation

@adutra
Copy link
Contributor
@adutra adutra commented Sep 30, 2015

Initially reported by DevCenter team.

@olim7t
Copy link
Contributor
olim7t commented Sep 30, 2015

I understand the rationale but making it public means we commit to its public/protected API forever. This raises a couple of issues:

  • the name is not great
  • could be an issue if we need to refactor in the future (e.g. add intermediary abstract classes in the hierarchy...)

Another way to approach this would be to make Options a top-level class (and rename it maybe), would that work?

On a side note, nullInitializedList can be replaced by Collections.fill.

@adutra
Copy link
Contributor Author
adutra commented Oct 1, 2015

Ok for making Options a top-level class, but do you have any suggestion for its name? I can't think of anything suitable :)

@adutra
Copy link
Contributor Author
adutra commented Oct 1, 2015

Turns out that Collections.fill is not suitable, but Collections.nCopies works.

@olim7t
Copy link
Contributor
olim7t commented Oct 11, 2015

Made the class top-level and renamed it to TableOptionsMetadata.

I accidentally rebased my local branch (sorry about that), so I ended up squashing my changes to the initial commit.

@tolbertam
Copy link
Contributor
tolbertam commented Oct 12, 2015

I rebased on 3.0 (was some merge conflicts due to changes for #478). This looks good to me 👍

@tolbertam tolbertam mentioned this pull request Oct 12, 2015
Merged
olim7t added a commit that referenced this pull request Oct 14, 2015
@olim7t
Merge pull request #463 from datastax/java825b
b531ee4 
Make TableOrView public to allow TableOrView.Option to be referenced outside package.
@olim7t olim7t merged commit b531ee4 into 3.0 Oct 14, 2015
@olim7t olim7t deleted the java825b branch October 14, 2015 20:16
Sfurti-yb pushed a commit to yugabyte/cassandra-java-driver that referenced this pull request Dec 8, 2023
@mp911de
Let Statement.add() always create a new binding set.
e2403fa 
[resolves apache#463]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

reviewed_AT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adutra @olim7t @tolbertam
0