8000 Decouple entities from keyspace in driver-mapping. by dananderson · Pull Request #222 · apache/cassandra-java-driver · GitHub
[go: up one dir, main page]

Skip to content

Decouple entities from keyspace in driver-mapping.#222

Closed
dananderson wants to merge 4 commits intoapache:2.1from
dananderson:2.1
Closed

Decouple entities from keyspace in driver-mapping.#222
dananderson wants to merge 4 commits intoapache:2.1from
dananderson:2.1

Conversation

@dananderson
Copy link

The keyspace parameter of the Table annotation is now optional. If an entity does not specify a keyspace
in Table, the keyspace from the MappingManager's Session will be used.

I created a JIRA ticket to track this issue: JAVA-442

The keyspace parameter of the Table annotation is now optional. If an entity does not specify a keyspace
in Table, the keyspace from the MappingManager's Session will be used.
@olim7t
Copy link
Contributor
olim7t commented Sep 8, 2014

Thanks. A few comments:

  • could you add default "" on the UDT annotation as well?
  • it would be nice to cover that with a unit test. You can take MapperTest as an example, simplify the schema to the bare minimum (a table with one non-PK column that is a UDT with one field), and issue a session.execute("USE ks") at the beginning of the test.

If you don't have time for the test I can take care of it.

@dananderson
Copy link
Author

I missed the user data type annotation. I will fix that and add a unit test (this evening).

Thanks!

@olim7t
Copy link
Contributor
olim7t commented Sep 9, 2014

Looks good to me. One last detail: could you squash your two commits, and add "(JAVA-442)" at the end of the commit message (so that it gets linked in JIRA)?

The keyspace parameter of the Table annotation is now optional. If an entity does not specify a keyspace
in Table, the keyspace from the MappingManager's Session will be used.

(JAVA-442)
olim7t added a commit that referenced this pull request Sep 9, 2014
@olim7t
Copy link
Contributor
olim7t commented Sep 9, 2014

Merged.
GitHub doesn't detect it because I had to do it manually in order to keep just one commit, but your fix is now on the 2.1 branch.
Thanks!

@olim7t olim7t closed this Sep 9, 2014
Sfurti-yb pushed a commit to yugabyte/cassandra-java-driver that referenced this pull request Dec 8, 2023
FluxDiscardOnCancel replays source signals unless cancelling
the subscription. On cancellation, the subscriber requests Long.MAX_VALUE
to drain the source and discard elements that are emitted afterwards.

[closes apache#222]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0