JAVA-2938: servererrors.OverloadedException message is misleading #1547
Conversation
| public OverloadedException(@NonNull Node coordinator) { | ||
| super(coordinator, String.format("%s is bootstrapping", coordinator), null, false); | ||
| public OverloadedException(@NonNull Node coordinator, @NonNull String message) { | ||
| super(coordinator, message, null, false); |
There was a problem hiding this comment.
I think we could do as in 3.x and augment the original message with the coordinator address:
| super(coordinator, message, null, false); | |
| super(coordinator, String.format("%s was overloaded: %s", coordinator, message), null, false); |
There was a problem hiding this comment.
Agree. Uploaded a new version of the commit, used "is" instead of "was" to be in-synch with the other error message (bootstraping). But let me know if you prefer was to be in synch with 3.x
There was a problem hiding this comment.
@chicobento looking really good!
Do you mind adding an entry to the changelog as below:
4.11.2 (in progress)
- [bug] JAVA-2938: OverloadedException message is misleading
Also, we don't have tests covering the change. But I admit that the change is very small so I can live without a test for it.
Yup, I looked for TCs in that sense and I couldn't find any. |
There was a problem hiding this comment.
LGTM. Muito obrigado @chicobento 👍
|
@chicobento I committed directly to 4.x with a few modifications to make the changes compatible with the existing API. One last thing: could you please sign our CLA? Thanks! |
|
@chicobento sorry to insist: please sign our CLA, otherwise I will have to revert your change. Thanks! |
|
Sorry, Im on vacation and have been disconnected for the last days. Just
signed, hope it's fine now.
Tks,
Francisco
…On Fri, May 21, 2021, 5:49 AM Ale
8000
xandre Dutra ***@***.***> wrote:
@chicobento <https://github.com/chicobento> sorry to insist: please sign
our CLA, otherwise I will have to revert your change. Thanks!
https://cla.datastax.com/
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1547 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACERKR22FGVJ5RGBOSHDC7LTOYNAJANCNFSM432MXYTQ>
.
|
|
Thank you! Closing now. Boa sorte a até a próxima :-) |
OverloadedException is misleading probably due to a copy&paste mistake.
Adding the original server message to the exception, as in 3.x series.
Original thread: https://groups.google.com/a/lists.datastax.com/g/java-driver-user/c/KNPE34iOBgI/m/fWv5zOxNAQAJ