[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

将 GOOGLE_CHECK_NE 替换成 CHECK_NE #2349

Merged
merged 2 commits into from
Aug 8, 2023
Merged

将 GOOGLE_CHECK_NE 替换成 CHECK_NE #2349

merged 2 commits into from
Aug 8, 2023

Conversation

gulu-goolu
Copy link
Contributor

What problem does this PR solve?

GOOGLE_CHECK_NE 源自 protobuf，但是最新版本的 protobuf 去掉了这个宏定义，因此会导致编译出错。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):

无影响

  • Breaking backward compatibility(向后兼容性):

无影响

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@gulu-goolu gulu-goolu closed this Aug 7, 2023
@gulu-goolu gulu-goolu reopened this Aug 7, 2023
@wasphin wasphin merged commit e783f83 into apache:master Aug 8, 2023
32 checks passed
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
@gulu-goolu
将 GOOGLE_CHECK_NE 替换成 CHECK_NE (apache#2349)
b531a4a 
* replace GOOGLE_CHECK_NE with CHECK_NE
yanglimingcn pushed a commit to yanglimingcn/brpc that referenced this pull request Oct 31, 2023
@gulu-goolu
将 GOOGLE_CHECK_NE 替换成 CHECK_NE (apache#2349)
17c982d 
* replace GOOGLE_CHECK_NE with CHECK_NE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gulu-goolu @wasphin