8000 GH-46659: [C++] Fix export of extension arrays with binary view/string view storage by paleolimbot · Pull Request #46660 · apache/arrow · GitHub
[go: up one dir, main page]
Skip to content

GH-46659: [C++] Fix export of extension arrays with binary view/string view storage #46660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 4, 2025
Merged

GH-46659: [C++] Fix export of extension arrays with binary view/string view storage #46660

merged 7 commits into from
Jun 4, 2025

Conversation

paleolimbot
Copy link
Member
@paleolimbot paleolimbot commented Jun 1, 2025 •
edited by github-actions bot
Loading

Rationale for this change

Extension arrays exported with binary view/string view storage did not export the variadic sizes buffer which resulted in crashes when reimporting.

What changes are included in this PR?

The expression that controlled whether the variadic sizes buffer was written was updated.

Are these changes tested?

Yes, a test was added

Are there any user-facing changes?

No

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 1, 2025

⚠️ GitHub issue #46659 has been automatically assigned in GitHub to PR creator.

@paleolimbot paleolimbot marked this pull request as ready for review June 1, 2025 04:05
@kou kou mentioned this pull request Jun 1, 2025
Closed
@paleolimbot
Copy link
Member Author

@bkietz Any chance you have a minute to ensure I understood this correctly?

bkietz
bkietz approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member
@bkietz bkietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me, just a few nits

8000
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 4, 2025
paleolimbot and others added 3 commits June 4, 2025 14:46
@paleolimbot @bkietz
Update cpp/src/arrow/testing/extension_type.h
5e0c8ed 
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
@paleolimbot @bkietz
Update cpp/src/arrow/c/bridge.cc
778383c 
Co-authored-by: Benjamin Kietzman <bengilgit@gmail.com>
@paleolimbot
use storage_id()!
54853fc
@paleolimbot
Copy link
Member Author

Thank you for the review!

@paleolimbot paleolimbot merged commit 610c201 into apache:main Jun 4, 2025
39 of 43 checks passed
@paleolimbot paleolimbot removed the awaiting merge Awaiting merge label Jun 4, 2025
@conbench-apache-arrow conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 610c201.

There were 70 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkietz bkietz bkietz approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paleolimbot @bkietz
0