8000 ARROW-3392: [Python] Support filters in disjunctive normal form in ParquetDataset by xhochy · Pull Request #2677 · apache/arrow · GitHub
[go: up one dir, main page]
Skip to content

ARROW-3392: [Python] Support filters in disjunctive normal form in ParquetDataset #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

ARROW-3392: [Python] Support filters in disjunctive normal form in ParquetDataset #2677

wants to merge 2 commits into from

Conversation

xhochy
Copy link
Member
@xhochy xhochy commented Oct 1, 2018

No description provided.

@xhochy
Copy link
Member Author
xhochy commented Oct 1, 2018

cc @rgruener

@xhochy
Copy link
Member Author
xhochy commented Oct 2, 2018

This hits pandas-dev/pandas#21688 with Pandas 0.23.x

@codecov-io
Copy link

Codecov Report

Merging #2677 into master will increase coverage by 1.01%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2677      +/-   ##
==========================================
+ Coverage    87.5%   88.51%   +1.01%     
==========================================
  Files         403      342      -61     
  Lines       61346    57580    -3766     
==========================================
- Hits        53678    50966    -2712     
+ Misses       7598     6614     -984     
+ Partials       70        0      -70
Impacted Files Coverage Δ
python/pyarrow/tests/test_parquet.py 97.48% <100%> (+0.03%) ⬆️
python/pyarrow/parquet.py 93.69% <96.55%> (+0.1%) ⬆️
cpp/src/arrow/csv/column-builder.cc 94.92% <0%> (-2.18%) ⬇️
rust/src/record_batch.rs
go/arrow/datatype_nested.go
rust/src/util/bit_util.rs
go/arrow/math/uint64_amd64.go
go/arrow/internal/testing/tools/bool.go
go/arrow/internal/bitutil/bitutil.go
go/arrow/memory/memory_avx2_amd64.go
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c7bded...acea955. Read the comment docs.

wesm
wesm approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member
@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

python/pyarrow/parquet.py

This function also supports passing in as List[Tuple]. These predicates
are evaluated as a conjunction. To express OR in predictates, one must
use the (preferred) List[List[Tuple]] notation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be good to add a Sphinx section giving some examples about DNF. The term wasn't familiar to me right away

@wesm
Copy link
Member
wesm commented Oct 2, 2018

Do you want to add docs in this patch? Otherwise I can merge

@xhochy
Copy link
Member Author
xhochy commented Oct 2, 2018

Feel free to merge. Once the full predicate pushdown support is merged, I will have to add a lot more documentation.

@wesm wesm closed this in 94352b7 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesm wesm wesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xhochy @codecov-io @wesm
0