feat: Add owner_links field to DAGDetailsResponse #50557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
approved these changes
May 13, 2025
jason810496
approved these changes
May 14, 2025
bugraoz93
approved these changes
May 14, 2025
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker e37a40d v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
May 14, 2025
* feat: Add owner_links field to DAGDetailsResponse model and update related schemas * remove owner_links in test code * add tests for DAG owner_links in DAG details endpoint * refactor: apply ruff formatting to test_dags.py (cherry picked from commit e37a40d)
|
Manual cherry pick PR here: |
pierrejeambrun
added a commit
that referenced
this pull request
May 14, 2025
* feat: Add owner_links field to DAGDetailsResponse model and update related schemas * remove owner_links in test code * add tests for DAG owner_links in DAG details endpoint * refactor: apply ruff formatting to test_dags.py (cherry picked from commit e37a40d) Co-authored-by: Yeonguk <choo121600@gmail.com>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
* feat: Add owner_links field to DAGDetailsResponse model and update related schemas * remove owner_links in test code * add tests for DAG owner_links in DAG details endpoint * refactor: apply ruff formatting to test_dags.py (cherry picked from commit e37a40d) Co-authored-by: Yeonguk <choo121600@gmail.com>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* feat: Add owner_links field to DAGDetailsResponse model and update related schemas * remove owner_links in test code * add tests for DAG owner_links in DAG details endpoint * refactor: apply ruff formatting to test_dags.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the owner_links field to the DAGDetailsResponse object from api_fastapi/core_api in order to resolve #48562
When the UI was based on Flask AppBuilder (FAB), we could retrieve the owner link using the following method:
However, now that the UI has been changed to React, this method no longer works. In the React UI, we need to retrieve the owner_links data from the API, which is why it needed to be included in the DAGDetailsResponse.
In the current implementation, owner_links is stored as a dictionary like:
I have preserved this format and added the owner_links field to the DAGDetailsResponse. This allows the UI to receive and render the owner_links data via the API response.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.