Disables --warn-unused-ignore flag for mypy #10880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem with MyPy's implementation of --warn-unused-ignore flag, that depending on it's incremental or full run it will sometimes throw an "unused ignore" error (entirely randomly it seems). The problem is described (but only workarounded) in python/mypy#2960. The workaround is to disable --warn-unused-ignore flag. There is little harm in having unused ignores and we can clean them up from time to time easily.
kaxil
approved these changes
Sep 11, 2020
3131575 to
e426750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with MyPy's implementation of
--warn-unused-ignore flag, that depending on it's incremental
or full run it will sometimes throw an "unused ignore" error
(entirely randomly it seems). The problem is described
(but only workarounded) in
python/mypy#2960.
The workaround is to disable --warn-unused-ignore flag.
There is little harm in having unused ignores and we can
clean them up from time to time easily.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.