[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor mermaid #923

Merged
merged 9 commits into from
Jul 3, 2020
Merged

Refactor mermaid #923

merged 9 commits into from
Jul 3, 2020

Conversation

ashwinsajiv
Copy link
Contributor

Changes proposed in this pull request:

  • Escape string in printed mermaid code
  • Added epa diagram gen for specific applications

@codecov
Copy link
codecov bot commented Jun 29, 2020 •
edited

Codecov Report

Merging #923 into master will increase coverage by 0.03%.
The diff coverage is 86.55%.

@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   83.35%   83.39%   +0.03%     
==========================================
  Files          73       75       +2     
  Lines       10609    10785     +176     
==========================================
+ Hits         8843     8994     +151     
- Misses       1432     1451      +19     
- Partials      334      340       +6
Impacted Files Coverage Δ
pkg/pbutil/output.go 76.00% <ø> (-0.48%) ⬇️
pkg/importer/importer.go 63.15% <63.15%> (ø)
pkg/mod/gomod.go 73.68% <66.66%> (+1.27%) ⬆️
pkg/parse/listener_impl.go 89.59% <66.66%> (+0.08%) ⬆️
pkg/parse/parse.go 83.47% <69.56%> (-0.50%) ⬇️
pkg/mod/module.go 66.66% <72.72%> (+0.95%) ⬆️
pkg/importer/swagger.go 76.00% <73.33%> (-3.60%) ⬇️
pkg/importer/formats.go 77.27% <77.27%> (ø)
pkg/importer/openapi.go 89.42% <88.98%> (-0.02%) ⬇️
pkg/importer/xsd.go 91.01% <95.23%> (+0.64%) ⬆️
... and 10 more

@ashwinsajiv ashwinsajiv mentioned this pull request Jun 29, 2020
Closed
cuminandpaprika
cuminandpaprika approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor
@cuminandpaprika cuminandpaprika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , just one nitpick on comment phrasing

pkg/mermaid/endpointanalysisdiagram/endpointanalysisdiagram.go Outdated Show resolved Hide resolved
@ashwinsajiv ashwinsajiv merged commit db11277 into anz-bank:master Jul 3, 2020
anzopensource pushed a commit that referenced this pull request Jun 11, 2024
@AriehSchneier
Don't import openapi2 array as list (#923)
bb2cdd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuminandpaprika cuminandpaprika cuminandpaprika approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashwinsajiv @cuminandpaprika