8000 --write: Add MatchError.yaml_path for transforms by cognifloyd · Pull Request #2025 · ansible/ansible-lint · GitHub
[go: up one dir, main page]
Skip to content

--write: Add MatchError.yaml_path for transforms #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 20, 2022
Merged

--write: Add MatchError.yaml_path for transforms #2025

merged 5 commits into from
Mar 20, 2022

Conversation

cognifloyd
Copy link
Contributor

Transforms need to know where to edit in the YAML data structures. So, we record the path to that location in MatchError.yaml_path and provide a seek() utility to descend to that location.

8000
@cognifloyd
Add match.yaml_path to record path to error in file
79b1a13
@cognifloyd
Add TransformMixin.seek utility method
c99ab32 
This is used to find where in the YAML data a rule needs to make transforms.
It can use ``match.yaml_path`` to identify the target section of data.
@cognifloyd cognifloyd requested a review from a team as a code owner March 19, 2022 14:39
@cognifloyd cognifloyd self-assigned this Mar 19, 2022
@cognifloyd cognifloyd requested review from ssbarnea and removed request for a team March 19, 2022 14:39
@cognifloyd
Copy link
Contributor Author

I debated using the enhancement or the skip-changelog label. Feel free to change it.

cognifloyd
cognifloyd commented Mar 19, 2022
View reviewed changes
cognifloyd
cognifloyd commented Mar 19, 2022
View reviewed changes
@cognifloyd cognifloyd changed the title Add MatchError.yaml_path for transforms --write: Add MatchError.yaml_path for transforms Mar 19, 2022
@ssbarnea ssbarnea merged commit 88bf6e8 into ansible:main Mar 20, 2022
@ssbarnea ssbarnea changed the title --write: Add MatchError.yaml_path for transforms --write: Add MatchError.yaml_path for transforms Mar 21, 2022
@ssbarnea ssbarnea mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees

@cognifloyd cognifloyd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cognifloyd @ssbarnea
0