fix: allow user plugins to override built-in auth plugins #11058
Conversation
Change .find() to .findLast() in CLI auth flow so user plugins take precedence over internal plugins (e.g., github-copilot). This aligns CLI behavior with ProviderAuth.methods() which already uses last-wins semantics via fromEntries().
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: feat(auth): merge auth methods from multiple plugins for same provider This PR appears related because it addresses how auth methods are merged from multiple plugins for the same provider. Your PR (11058) is about ensuring user plugins can override built-in auth plugins, which is related to how multiple plugins providing the same auth method are handled and prioritized. These PRs may be addressing related or overlapping concerns around plugin precedence and auth method resolution, so it would be worth checking if one approach conflicts with or complements the other. |
Change
.find()to.findLast()in CLI auth flow so user plugins take precedence over internal plugins (e.g., github-copilot). This aligns CLI behavior withProviderAuth.methods()which already uses last-wins semantics viafromEntries().What does this PR do?
Fixes a bug where user/external plugins cannot override built-in auth plugins. The root cause is that
Plugin.list()returns internal plugins first, then user plugins. The CLI auth command used.find()(first match wins), meaning the built-in plugin always took precedence. Meanwhile,ProviderAuth.methods()(used by TUI) already usedfromEntries()which is last-wins.This PR changes two
.find()calls to.findLast()inpackages/opencode/src/cli/cmd/auth.tsso user plugins can fully override built-in auth behavior (e.g., a company plugin replacing the default GitHub Copilot OAuth flow with a custom enterprise auth).How did you verify your code works?
Added
packages/opencode/test/plugin/auth-override.test.tswhich:auth.provider: "github-copilot"with a custom methodProviderAuth.methods()and asserts the user plugin's method takes precedence over the built-in