8000 minify templates by buberdds · Pull Request #207 · angular-app/angular-app · GitHub
[go: up one dir, main page]
Skip to content

minify templates #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
buberdds wants to merge 1 commit into from
Closed

minify templates #207

buberdds wants to merge 1 commit into from

Conversation

@buberdds
Copy link
Contributor
@buberdds buberdds commented Nov 26, 2013

Hi there,

I'm trying to resolve issue #95 and I need your feedback. Is this sollution ok, or you expect something else?
Run minify process only while in a release task maybe?

pkozlowski-opensource added a commit to pkozlowski-opensource/angular-app that referenced this pull request Aug 6, 2014
@pkozlowski-opensource
feat: add templates minification
367993b 
Fixes angular-app#95
Closes angular-app#207
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Aug 6, 2014
Closed
pkozlowski-opensource added a commit that referenced this pull request Aug 16, 2014
@pkozlowski-opensource
feat: add templates minification
f1e4e68 
Fixes #95
Closes #207

Closes #251
@pkozlowski-opensource
Copy link
Member
pkozlowski-opensource commented Aug 16, 2014

@buberdds I'm so sorry that it took us so much time to get back to you, we should be better at managing PRs :-/

So, the breaking news is that we are starting work on the second edition of the book and as part of this effort going to update this sample app. For the update we've decided to go with gulp and so our build won't look the same.

Both Peter and I really appreciate your work but just don't want to merge this PR now in order to avoid merge conflicts in the future. FYI, here is how the new build with minifcation is going to look like:
#251

pkozlowski-opensource added a commit that referenced this pull request Sep 1, 2014
@pkozlowski-opensource @petebacondarwin
feat: add templates minification
609c635 
Fixes #95
Closes #207

Closes #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buberdds @pkozlowski-opensource
0