10000 Replace arrays and `HashMap` with native `Map` (with a fallback shim implementation) by gkalpak · Pull Request #15114 · angular/angular.js · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Replace arrays and HashMap with native Map (with a fallback shim implementation) #15114

Closed
wants to merge 9 commits into from
Closed

Replace arrays and HashMap with native Map (with a fallback shim implementation) #15114

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1c187d7
perf(copy): use ES6 Map to track source/destination objects
jbedard Oct 30, 2015
8f4eab4
fixup! perf(copy): Saving the last key/index lookup in ESMapShim
jbedard Dec 11, 2015
95f9179
fixup! perf(copy): replace Map feature-test with native-test
jbedard Aug 27, 2016
4db3ac1
refactor(copy): avoid creating source/dest Map for simple copies
jbedard Aug 28, 2016
fdba297
refactor(HashMap): use `ES6Map` under the hood
gkalpak Sep 9, 2016
a83f60e
refactor(*): replace `HashMap` with `NgMap` (former `ES6Map`)
gkalpak Sep 9, 2016
dcbb707
test(hashKey): add tests for `hashKey()`
gkalpak Sep 9, 2016
604d876
fixup! refactor(*): replace `HashMap` with `NgMap` (former `ES6Map`)
gkalpak Sep 10, 2016
a7f8d63
fixup! refactor(*): replace `HashMap` with `NgMap` (former `ES6Map`)
gkalpak Dec 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! perf(copy): Saving the last key/index lookup in ESMapShim
  • Loading branch information
@jbedard @gkalpak
jbedard authored and gkalpak committed Sep 9, 2016
commit 8f4eab4d0e3ff877008ad55a8622fd1d308885af
15 changes: 12 additions & 3 deletions src/Angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,18 +753,27 @@ function arrayRemove(array, value) {
function ES6MapShim() {
this._keys = [];
this._values = [];
this._lastKey = NaN;
this._lastIndex = -1;
}
ES6MapShim.prototype = {
_idx: function(key) {
if (key === this._lastKey) {
return this._lastIndex;
}
return (this._lastIndex = (this._keys.indexOf(this._lastKey = key)));
},
get: function(key) {
var idx = this._keys.indexOf(key);
var idx = this._idx(key);
if (idx !== -1) {
return this._values[idx];
}
},
set: function(key, value) {
var idx = this._keys.indexOf(key);
var idx = this._idx(key);
if (idx === -1) {
idx = this._keys.length;
idx = this._lastIndex = this._keys.length;
this._lastKey = key;
}
this._keys[idx] = key;
this._values[idx] = value;
Expand Down
0