This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngRoute):change pathRegExp to respect optional wildcard route params #14011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rams change pathRegExp to accept the two-character option of '*?' on route params to allow them to be wildcard and optional at the same time. Motivation for change inspired by the need to accept an auth token on the URL that contained slashes (need for wildcard param) but this token on the URL was not required (need for optional param). Previous behavior only saw the param as wildcard and not optional, which resulted in the need for a trailing slash on the url (e.g. /login/ vs. /login) new feature - does not address any open issues
| "grunt-bump": "~0.0.13", | ||
| "grunt-contrib-clean": "~0.6.0", | ||
| "grunt-contrib-compress": "~0.12.0", | ||
| "grunt-contrib-connect": "~0.8.0", | ||
| "grunt-contrib-copy": "~0.6.0", | ||
| "grunt-contrib-jshint": "~0.10.0", | ||
| "grunt-contrib-jshint": "https://registry.npmjs.org/grunt-contrib-jshint/-/grunt-contrib-jshint-0.10.0.tgz", |
There was a problem hiding this comment.
These changes should be removed.
|
LGTM with the comments addressed 👍 |
added 2 commits
February 11, 2016 12:26
…rams change pathRegExp to accept the two-character option of '*?' on route params to allow them to be wildcard and optional at the same time. Motivation for change inspired by the need to accept an auth token on the URL that contained slashes (need for wildcard param) but this token on the URL was not required (need for optional param). Previous behavior only saw the param as wildcard and not optional, which resulted in the need for a trailing slash on the url (e.g. /login/ vs. /login) new feature - does not address any open issues
…rams change pathRegExp to accept the two-character option of '*?' on route params to allow them to be wildcard and optional at the same time. Motivation for change inspired by the need to accept an auth token on the URL that contained slashes (need for wildcard param) but this token on the URL was not required (need for optional param). Previous behavior only saw the param as wildcard and not optional, which resulted in the need for a trailing slash on the url (e.g. /login/ vs. /login) new feature - does not address any open issues
|
apologies for the miss, everything should be set now. |
|
@gkalpak Let me know if there is any other work you see that needs to be done (I believe I've satisfied the issues you've commented on). Thank you! |
gkalpak
pushed a commit
that referenced
this pull request
Feb 16, 2016
gkalpak
pushed a commit
that referenced
this pull request
Feb 16, 2016
|
Merged ! Thx @murphomatic 👍 |
|
Awesome! Thanks @gkalpak! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change pathRegExp to accept the two-character option of '*?' on route params to allow them to be wildcard and optional at the same time. Motivation for change inspired by the need to accept an auth token on the URL that contained slashes (need for wildcard param) but this token on the URL was not required (need for optional param). Previous behavior only saw the param as wildcard and not optional, which resulted in the need for a trailing slash on the url (e.g. /login/ vs. /login)
new feature - does not address any open issues