8000 Animate optimizations by dcherman · Pull Request #13879 · angular/angular.js · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Animate optimizations #13879

Closed
wants to merge 3 commits into from
Closed

Animate optimizations #13879

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb366d1
perf(ngRepeat): avoid duplicate jqLite wrappers
dcherman Jan 28, 2016
81ae59b
perf(ngAnimate): avoid $.fn.data overhead with jQuery
dcherman Jan 28, 2016
29f1eac
perf(ngAnimate): avoid jqLite/jQuery for upward DOM traversal
dcherman Feb 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
perf(ngRepeat): avoid duplicate jqLite wrappers 
Internally, `$animate` already wraps elements passed through with
`jqLite`, so we can avoid needless duplication here.
  • Loading branch information
@dcherman
dcherman committed Jan 28, 2016
commit bb366d1feff4297dd3057280396182a9d4a9a772
5 changes: 2 additions & 3 deletions src/ng/directive/ngRepeat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ var ngRepeatDirective = ['$parse', '$animate', function($parse, $animate) {

if (getBlockStart(block) != nextNode) {
// existing item which got moved
$animate.move(getBlockNodes(block.clone), null, jqLite(previousNode));
$animate.move(getBlockNodes(block.clone), null, previousNode);
}
previousNode = getBlockEnd(block);
updateScope(block.scope, index, valueIdentifier, value, keyIdentifier, key, collectionLength);
Expand All @@ -527,8 +527,7 @@ var ngRepeatDirective = ['$parse', '$animate', function($parse, $animate) {
var endNode = ngRepeatEndComment.cloneNode(false);
clone[clone.length++] = endNode;

// TODO(perf): support naked previousNode in `enter` to avoid creation of jqLite wrapper?
$animate.enter(clone, null, jqLite(previousNode));
$animate.enter(clone, null, previousNode);
previousNode = endNode;
// Note: We only need the first/last node of the cloned nodes.
// However, we need to keep the reference to the jqlite wrapper as it might be changed later
Expand Down
0