This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor: Refactor the equals function for readability #13650
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Turn an unnecessary nested if block into an &&
- Change the isRegExp block to use the same "if the second argument is the wrong type, return false" pattern as all the other blocks
- Turn an unnecessary nested if block into an && - Change the isRegExp block to use the same "if the second argument is the wrong type, return false" pattern as all the other blocks
|
LGTM (does exactly as the description says - git diffing adds much more noise 😃) |
|
It's true, the no-whitespace diff is a lot shorter. |
| if (!isDate(o2)) return false; | ||
| return equals(o1.getTime(), o2.getTime()); | ||
| } else if (isRegExp(o1)) { | ||
| if (!isRegExp(o2)) return false; |
There was a problem hiding this comment.
[nit] I find return isRegExp(o2) && o1.toString() == o2.toString(); easier to read, but not a blocker
There was a problem hiding this comment.
Me too, but every other if (some type) block used the other pattern, and the function as a whole seemed easier to read when they all followed the same pattern.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.