8000 Fix ngMock window.inject() error stack trace reporting on repeated or non-initial injection function calls for the master branch (issue #13594) by jurko-gospodnetic · Pull Request #13598 · angular/angular.js · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix ngMock window.inject() error stack trace reporting on repeated or non-initial injection function calls for the master branch (issue #13594) #13598

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix ngMock window.inject() error stack trace reporting on repeated or non-initial injection function calls for the master branch (issue #13594) #13598

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7724bc3
refactor(ngMock window.inject test): create room for planned tests
jurko-gospodnetic Dec 20, 2015
22d7209
refactor(ngMock window.inject test): add testInjectCaller() usage com…
jurko-gospodnetic Dec 20, 2015
4e78a7f
refactor(ngMock window.inject test): comment on important function wr…
jurko-gospodnetic Dec 20, 2015
c63a1e3
refactor(ngMock window.inject test): mark regression test for issue #…
jurko-gospodnetic Dec 20, 2015
4b0763f
fix(ngMock window.inject): correct error stack trace update on all in…
jurko-gospodnetic Dec 20, 2015
48f222c
test(ngMock window.inject): error stack trace on repeated injection c…
jurko-gospodnetic Dec 20, 2015
3a09c6d
test(ngMock windo 8000 w.inject): error stack trace on inject with multiple…
jurko-gospodnetic Dec 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(ngMock window.inject test): mark regression test for issue #… 
…13591
  • Loading branch information
@jurko-gospodnetic
jurko-gospodnetic committed Apr 11, 2016
commit c63a1e37abff9026f7fd5eda3f3d6144c7796cac
1 change: 1 addition & 0 deletions test/ngMock/angular-mocksSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,6 +972,7 @@ describe('ngMock', function() {
var throwingInjectingCall = testInjectCaller();
throwingInjectingCall.setThrow(true);

// regression test for issue #13591 when run on IE10+ or PhantomJS
it('should update thrown Error stack trace with inject call location', function() {
try {
throwingInjectingCall();
Expand Down
0