8000 refact(ngOptions): major refactoring... by petebacondarwin · Pull Request #10639 · angular/angular.js · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refact(ngOptions): major refactoring... #10639

Closed
wants to merge 9 commits into from
Closed

refact(ngOptions): major refactoring... #10639

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d43d943
fix(ngOptions): ensure that the correct option is selected when optio…
petebacondarwin Jan 4, 2015
578e8c4
refact(ngOptions): move into its own file
petebacondarwin Jan 10, 2015
b4b6822
test(ngOptions): should place non-grouped items in the list where the…
petebacondarwin Jan 10, 2015
94ae280
test(ngOptions): should not insert a blank option if one of the optio…
petebacondarwin Jan 10, 2015
599e5b8
style(ngOptionsSpec): add extra newline for better formatting
petebacondarwin Jan 11, 2015
2d0a0a5
fix(ngOptions): update model if selected option is removed
petebacondarwin Jan 11, 2015
de7c178
refact(ngOptions): specialize readValue and writeValue based on multi…
petebacondarwin Jan 11, 2015
4725ddb
fix(ngOptions): prevent infinite digest if track by expression is stable
petebacondarwin Jan 11, 2015
70e5015
fix(ngOptions): support one-time binding on the option values
petebacondarwin Jan 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(ngOptions): should place non-grouped items in the list where the… 
…y appear

Closes #10531
  • Loading branch information
@petebacondarwin
petebacondarwin committed Jan 12, 2015
commit b4b682243394bde83c53340a06fd0072812c8349
30 changes: 30 additions & 0 deletions test/ng/directive/ngOptionsSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,36 @@ describe('ngOptions', function() {
});


it('should place non-grouped items in the list where they appear', function() {
createSelect({
'ng-model': 'selected',
'ng-options': 'item.name group by item.group for item in values'
});

scope.$apply(function() {
scope.values = [{name: 'A'},
{name: 'B', group: 'first'},
{name: 'C', group: 'second'},
{name: 'D'},
{name: 'E', group: 'first'},
{name: 'F'},
{name: 'G'},
{name: 'H', group: 'second'}];
scope.selected = scope.values[0];
});

var children = element.children();
expect(children.length).toEqual(6);

expect(nodeName_(children[0])).toEqual('option');
expect(nodeName_(children[1])).toEqual('optgroup');
expect(nodeName_(children[2])).toEqual('optgroup');
expect(nodeName_(children[3])).toEqual('option');
expect(nodeName_(children[4])).toEqual('option');
expect(nodeName_(children[5])).toEqual('option');
});


it('should bind to scope value and track/identify objects', function() {
createSelect({
'ng-model': 'selected',
Expand Down
0