8000 docs(dependency-injection): add Dart version, tweak TS version by kwalrath · Pull Request #972 · angular/angular.io · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

docs(dependency-injection): add Dart version, tweak TS version #972

Closed
wants to merge 20 commits into from
Closed

docs(dependency-injection): add Dart version, tweak TS version #972

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3b52317
Straight copy of content, no changes except a few omissions
kwalrath Mar 4, 2016
1bbbc27
Include Dart samples, not TS samples.
kwalrath Mar 4, 2016
10dab8a
shorten line length in some sample code
kwalrath Mar 7, 2016
74cd216
Tweak samples
kwalrath Mar 8, 2016
46a4a9a
tweak code
kwalrath Mar 11, 2016
2b18715
first draft of Dart text
kwalrath Mar 11, 2016
f13d0fd
make output of Dart app match TS app's output
kwalrath Mar 11, 2016
505f720
fix script tags in index.html
kwalrath Mar 14, 2016
ea1b774
sample cleanup
kwalrath Mar 16, 2016
b362c1d
more code cleanups
kwalrath Mar 16, 2016
614a49b
midway through incorporating thso's comments...
kwalrath Mar 16, 2016
0d7fbc4
a few more changes, incorporating thso's feedback
kwalrath Mar 16, 2016
9409bb4
code tweaks suggested by thso
kwalrath Mar 16, 2016
39d0b6f
delete "we probably already know" filler...
kwalrath Mar 17, 2016
225f3b4
incorporate more comments from thso
kwalrath Mar 21, 2016
835cfbb
user core.dart, b.12, much new code
kwalrath Mar 25, 2016
537a5c9
Change appConfig to use a class (and still useValue)
kwalrath Mar 25, 2016
5f40a6e
fix text to reflect new code
kwalrath Mar 25, 2016
e51f569
clean up last section and code includes
kwalrath Mar 25, 2016
a145b2d
final cleanup!
kwalrath Mar 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak samples
  • Loading branch information
@kwalrath
kwalrath committed Mar 25, 2016
commit 74cd216093e4567b8802f7b3a6df3c4941641b05
1 change: 1 addition & 0 deletions public/docs/_examples/dependency-injection/dart/lib/car/car_factory.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// #docregion
import 'car.dart';

// BAD pattern!
class CarFactory {
Car createCar() {
var car = new Car(createEngine(), createTires());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could showcase the cascade operator here:

return new Car(createEngine(), createTires())..description = 'Factory';

Expand Down
4 changes: 2 additions & 2 deletions public/docs/_examples/dependency-injection/dart/lib/car/car_no_di.dart
View file
Open in desktop
8000
Original file line numberDiff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ class Car {
engine = new Engine();
tires = new Tires();
}

//#enddocregion car-ctor

// Method using the engine and tires
drive() => '$description car with ${engine.cylinders} cylinders and ${tires.make} tires.';
drive() => '$description car with '
'${engine.cylinders} cylinders and ${tires.make} tires.';
}
//#enddocregion car
2 changes: 1 addition & 1 deletion public/docs/_examples/dependency-injection/dart/lib/heroes/heroes_component_1.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import 'package:angular2/angular2.dart';
import 'hero_list_component.dart';
// #enddocregion v1
import 'hero_service.dart';

// #docregion v1

@Component(
selector: 'my-heroes',
template: '''
Expand Down
59 changes: 26 additions & 33 deletions public/docs/_examples/dependency-injection/dart/lib/providers_component.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ class ProviderComponent2 {
String log;

ProviderComponent2(Logger logger) {
logger.log(
'Hello from logger provided with Provider class and useClass');
logger.log('Hello from logger provided with Provider class and useClass');
log = logger.logs[0];
}
}
Expand Down Expand Up @@ -75,8 +74,7 @@ class ProviderComponent4 {
String log;

ProviderComponent4(Logger logger) {
logger
.log('Hello from logger provided with useClass:BetterLogger');
logger.log('Hello from logger provided with useClass:BetterLogger');
log = logger.logs[0];
}
}
Expand All @@ -100, 10000 10 +98,7 @@ class EvenBetterLogger implements Logger {
// #enddocregion EvenBetterLogger
@Component(selector: 'provider-5', template: '{{log}}', providers:
//#docregion providers-5
const [
UserService,
const Provider(Logger, useClass: EvenBetterLogger)
]
const [UserService, const Provider(Logger, useClass: EvenBetterLogger)]
//#enddocregion providers-5
)
class ProviderComponent5 {
Expand Down Expand Up @@ -139,8 +134,7 @@ class ProviderComponent6a {

ProviderComponent6a(NewLogger newLogger, OldLogger oldLogger) {
if (identical(newLogger, oldLogger)) {
throw new Exception(
'expected the two loggers to be different instances');
throw new Exception('expected the two loggers to be different instances');
}
oldLogger.log('Hello OldLogger (but we want NewLogger)');
// The newLogger wasn't called so no logs[]
Expand All @@ -165,8 +159,7 @@ class ProviderComponent6b {

ProviderComponent6b(NewLogger newLogger, OldLogger oldLogger) {
if (!identical(newLogger, oldLogger)) {
throw new Exception(
'expected the two loggers to be the same instance');
throw new Exception('expected the two loggers to be the same instance');
}
oldLogger.log('Hello from NewLogger (via aliased OldLogger)');
log = newLogger.logs[0];
Expand All @@ -175,17 +168,16 @@ class ProviderComponent6b {

// #docregion silent-logger
// An object in the shape of the logger service
class SilentLogger /*implements Logger*/ {
const SilentLogger({this.logs});
class SilentLogger {
final List<String> logs = const [
'Silent logger says "Shhhhh!". Provided via "useValue"'];

final List<String> logs;
const SilentLogger();

log(String message) {}
void log(String msg) {}
}

const silentLogger = const SilentLogger(logs: const [
'Silent logger says "Shhhhh!". Provided via "useValue"'
]);
const silentLogger = const SilentLogger();
// #enddocregion silent-logger

@Component(selector: 'provider-7', template: '{{log}}', providers:
Expand All @@ -207,14 +199,11 @@ class ProviderComponent7 {
}
}

@Component(
selector: 'provider-8',
template: '{{log}}',
providers: const [
const Provider(HeroService, useFactory: heroServiceFactory),
Logger,
UserService
])
@Component(selector: 'provider-8', template: '{{log}}', providers: const [
const Provider(HeroService, useFactory: heroServiceFactory),
Logger,
UserService
])
class ProviderComponent8 {
// #docregion provider-8-ctor
ProviderComponent8(HeroService heroService);
Expand Down Expand Up @@ -267,9 +256,7 @@ class ProviderComponent9a implements OnInit {

@Component(selector: 'provider-9b', template: '{{log}}', providers:
// #docregion providers-9b
const [
const Provider(APP_CONFIG, useValue: CONFIG_HASH)
])
const [const Provider(APP_CONFIG, useValue: CONFIG_HASH)])
// #enddocregion providers-9b
class ProviderComponent9b implements OnInit {
Config _config;
Expand Down Expand Up @@ -303,6 +290,13 @@ class ProviderComponent10a {
}
}

class DoNothingLogger extends Logger {
log(String msg) {
logs.add(msg);
}
List<String> logs;
}

// Optional logger
@Component(selector: 'provider-10b', template: '{{log}}')
class ProviderComponent10b implements OnInit {
Expand All @@ -318,12 +312,11 @@ class ProviderComponent10b implements OnInit {
// #docregion provider-10-logger
// No logger? Make one!
if (_logger == null) {
_logger = new Logger();
_logger = new DoNothingLogger();
// #enddocregion provider-10-logger
_logger.log('Optional logger was not available.');
_logger.log('Nothing to see here.');
} else {
_logger.log('Hello from the injected logger.');
log = _logger.logs[0];
}
log = _logger.logs[0];
}
Expand Down
0