8000 #128: 5 Min Quickstart small issue fix & #119: Download page formatting by WonSong · Pull Request #129 · angular/angular.io · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Dec 4, 2017. It is now read-only.

#128: 5 Min Quickstart small issue fix & #119: Download page formatting #129

Merged
merged 3 commits into from
May 20, 2015
Merged

#128: 5 Min Quickstart small issue fix & #119: Download page formatting #129

merged 3 commits into from
May 20, 2015

Conversation

WonSong
Copy link
Contributor
@WonSong WonSong commented May 20, 2015

Creating a pull request in case this is a real issue.

Before:

image

After:

image

#128
8300295 
Added /// and enclosing slash
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@WonSong
Copy link
Contributor Author
WonSong commented May 20, 2015

Signed it

@googlebot
Copy link

CLAs look good, thanks!

@WonSong WonSong changed the title #128 #128: 5 Min Quickstart small issue fix May 20, 2015
#119
dc1bafd 
1. Removed X from 1.x titles
2. Replaced links with hover cards
3. Changed Download to Install
@WonSong
Copy link
Contributor Author
WonSong commented May 20, 2015

Before:

image

image

After:

image

image

@WonSong WonSong changed the title #128: 5 Min Quickstart small issue fix #128: 5 Min Quickstart small issue fix & #119: Download page formatting May 20, 2015
@WonSong WonSong mentioned this pull request May 20, 2015
Closed
alexwolfe
alexwolfe reviewed May 20, 2015
View reviewed changes
public/resources/css/module/_card.scss
&.hover-card-container {
margin-left: 0;
margin-top: $unit * 2;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should just replace the entire containers on the install page with the cards instead of putting them inside the card module. You should then be able to remove these extras styles. Thanks.

@alexwolfe
Copy link
Contributor

@WonSong This is great work, thanks! I just had one comment otherwise looks good. Ping me when updated and I'll merge. Thanks!

#119
93bc37f 
1. Changed the download page layout per feedback.
2. Removed custom styles added.
3. 0 to layout loop.... because I couldn't find a better way to remove padding left on UL :(
@WonSong
Copy link
Contributor Author
WonSong commented May 20, 2015

@alexwolfe Np & Thanks! Please review.

I did the below unwillingly because I wasn't able to find a helper class to remove padding left on the <ul>.

-@for $i from 1 through 10 {
+@for $i from 0 through 10 {

Would you have preferred replacing <ul> with a <div> tag or something instead?

image

@im-tollu im-tollu mentioned this pull request May 20, 2015
Closed
@alexwolfe
Copy link
Contributor

@WonSong 👍 Nice work, thanks for the fixes.

alexwolfe pushed a commit that referenced this pull request May 20, 2015
Merge pull request #129 from WonSong/master
d8fcbaa 
#128: 5 Min Quickstart small issue fix & #119: Download page formatting
@alexwolfe alexwolfe merged commit d8fcbaa into 6E57 angular:master May 20, 2015
@WonSong WonSong mentioned this pull request May 20, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WonSong @googlebot @alexwolfe
0